Pelles C forum

Pelles C => Bug reports => Topic started by: czerny on November 19, 2014, 12:32:25 PM

Title: wizard icon
Post by: czerny on November 19, 2014, 12:32:25 PM
The help says, that an icon with the ordinal #1 as resource in the dll is used as wizard icon. Most of the standard wizards have such an icon included, but it is not displayed. See the picture as an example for msvcproj.dll. You can see the 'new project' dialog, which shows not the icon on the left but a default icon.

Can you see the icon on the left in your ide?
Title: Re: wizard icon
Post by: czerny on November 20, 2014, 11:18:38 AM
Has it anybody managed to use a custom icon for a wizard?

How does the new project dialog look in your cases? Default icons?
Title: Re: wizard icon
Post by: czerny on November 22, 2014, 09:17:55 AM
can a moderator please move this in the bug section?
Title: Re: wizard icon
Post by: czerny on November 24, 2014, 08:19:08 AM
can a moderator please move this in the bug section?
Hmm! All mods in holidays?
Title: Re: wizard icon
Post by: TimoVJL on November 24, 2014, 10:07:44 AM
Works for me with v7 and v8. Remember to restart poide while working with it.
Title: Re: wizard icon
Post by: czerny on November 25, 2014, 09:50:50 AM
Thank you Timo,

I will try your example!

But I am also interested in an answer to my first question!

Is the dark blue icon used by your project new dialog? Or is it not?
It is included in msvcproj.dl as icon with ordinal #1.
Title: Re: wizard icon
Post by: czerny on November 25, 2014, 11:35:14 AM
Timo: I have tested your example under win7 and it works! The icons of all the other wizards are displayed ok too.

So this must be a problem with winXP (not to say win2k).

I can not remember to have seen this icons ever. I only know the appearance of the default icon (see image at my first post).

I will try your example once more at winXP when I have a XP computer available. It would be nice if anybody could test this too.

Btw. is there a significant change in icon formats under the newer windows Oses?
Title: Re: wizard icon
Post by: TimoVJL on November 25, 2014, 01:57:27 PM
Problem exist in PellesC v8 with WindowsXP. See differences in pictures.
EDIT: Just with commandline option /b that happens.
Quote
/b Forces the traditional user-interface look on Windows XP.
Title: Re: wizard icon
Post by: czerny on November 25, 2014, 02:20:37 PM
Problem exist in PellesC v8 with WindowsXP. See differences in pictures.
Thank you to verify this!

Can someone move this in the bug section, please?
Title: Re: wizard icon
Post by: czerny on November 25, 2014, 02:27:38 PM
Problem exist in PellesC v8 with WindowsXP. See differences in pictures.
There is an other difference. The newer dialog shows two sections, empty projects and template projects. Wherer is this difference be made in the wizard source code and why it is not shown in the older dialog? Is this a feature of a newer list view control?
Title: Re: wizard icon
Post by: czerny on November 25, 2014, 05:09:42 PM
Just something to do with Listview. I get that another view just first opening that Wizard with poide and then try to create new project.
Sorry! I don't understand.
Title: Re: wizard icon
Post by: czerny on November 25, 2014, 05:13:35 PM
There is an other difference. The newer dialog shows two sections, empty projects and template projects. Wherer is this difference be made in the wizard source code and why it is not shown in the older dialog? Is this a feature of a newer list view control?
LVGS_SUBSETED?
Title: Re: wizard icon
Post by: frankie on November 25, 2014, 07:14:51 PM
Problem exist in PellesC v8 with WindowsXP. See differences in pictures.
In my XP it's correct...
Title: Re: wizard icon
Post by: czerny on November 25, 2014, 07:59:06 PM
In my XP it's correct...
What version of ComCtl32.dll do yo have?
Title: Re: wizard icon
Post by: TimoVJL on November 25, 2014, 10:02:25 PM
Mine is 6.0.2900.2
Title: Re: wizard icon
Post by: czerny on November 26, 2014, 08:23:30 AM
Mine is 6.0.2900.2
I have the same version on XP!

Creation of the lib included!
Title: Re: wizard icon
Post by: czerny on November 26, 2014, 09:10:09 AM
I have a strange effect on my XP computer.
While I am trying Timos ComCtlGetVersion I suddenly had an other ide look. There were two triangels in the toolbar, to run and debug the project (hope you know what I mean).
Usually I have the toolbar on the attached image!
While I had this other toolbar I tryed the new project dialog and all icons are displayed ok.

I have tryed to reproduce this. But now I always get the usual toolbar (image) and the new project dialog with the default icons.
Title: Re: wizard icon
Post by: frankie on November 26, 2014, 09:34:54 AM
My ComCtl32.dll version is 5.82.2900.6028 (I have never updated IExplorer because I generally use Chrome).
Anyway my ComCtl32.ocx version is 6.0.81.5
Title: Re: wizard icon
Post by: czerny on November 26, 2014, 10:01:27 AM
I have the following versions of ComCtl32.dll on my XP machine:

5.82.2900.6028 (617472 bytes) in system32
5.82.2900.5512 (617472 bytes)
6.0.2600.0 (921088 bytes)
6.0.2900.2180 (1050624 bytes)
6.0.2900.5512 (1050208 bytes)
6.0.2900.6028 (1050208 bytes) this is found by Timo's code

Timo: I have used DLLVERSIONINFO2 here:

Code: [Select]
DLLVERSIONINFO2 dvi;
char szTmp[260];
dvi.info1.cbSize = sizeof(dvi);
DllGetVersion(&dvi.info1);
wsprintf(szTmp, "%d.%d.%d.%d",
(WORD)((dvi.ullVersion >> 48) & 0xFFFF),
(WORD)((dvi.ullVersion >> 32) & 0xFFFF),
(WORD)((dvi.ullVersion >> 16) & 0xFFFF),
(WORD)(dvi.ullVersion & 0xFFFF));

It is a little bit strange, that the dll-path
Code: [Select]
C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.2600.6028_x-ww_61e65202has 6.0.2600.6028 while the dll has 6.0.2900.6028 as version string.

Poide seems to use the same dll (process viewer).

Btw. all the comctl32.dll in C:\WINDOWS\WinSxS use the same public key token in its directory name. So it is not possible to force one of this dlls to load by a manifest.
Title: Re: wizard icon
Post by: TimoVJL on November 26, 2014, 10:48:40 AM
Thank's czerny.
Corrected code with ComCtlVer.lib and ComCtlVer64.lib too.
Title: Re: wizard icon
Post by: czerny on November 28, 2014, 09:57:35 AM
Some observations:

I usually have XP running not in XP-stil but in classic style.

Today, after booting the machine and starting Pelles C, I have the triangle toolbar and the new-project-dialog shows all the individual icons. I could close the ide and restart it, all remains ok.

So I decided to test if an reboot has any effect.

After the the reboot I got suddenly XP-style on my desktop automatically!  :-\
I don't understand this at all.

I started Pelles C: all ok.

I closed the IDE and changed to classic style: all wrong.

I changed to XP-style and started the IDE: all ok.

I changed to classic style (without closing the IDE): all ok.

Title: Re: wizard icon
Post by: tienkhoanguyen on November 29, 2014, 12:14:06 PM
The help says, that an icon with the ordinal #1 as resource in the dll is used as wizard icon. Most of the standard wizards have such an icon included, but it is not displayed. See the picture as an example for msvcproj.dll. You can see the 'new project' dialog, which shows not the icon on the left but a default icon.

Can you see the icon on the left in your ide?

I believe I have seen that left icon somewhere before maybe in Eclipse?  I used to work in Eclipse "trying" to program Android unfortunately had no luck.  I am incredibly stupid.   :)

However if you ever get the chance to use WinRAR 3.93 - I found it to be very efficient and fast; even found it faster than the 64-bit edition so that is weird.  Also you can use your own icons if you make a self-extracting WinRAR file.  Although it is NOT free.

Anyways, I just wanted to say I see that icon just in case you need another person to verify.

Have a happy Advent and Christmas!