Text only | Text with Images

Pelles C forum

Assembly language => Assembly discussions => Topic started by: Vortex on December 03, 2024, 08:17:07 PM

Title: Saving a bitmap from handle
Post by: Vortex on December 03, 2024, 08:17:07 PM
Hello,

Here is a function to save a bitmap from handle :

Code Select

include SaveBmpFromHandle.inc

.data

IID_IPicture GUID <7BF80980h,0BF32h,101Ah,<8Bh,0BBh,00h,0AAh,00h,30h,0Ch,0ABh>>

.code

SaveBmpFromHandle PROC hBitmap:QWORD,FileName:QWORD PARMAREA=4*QWORD

LOCAL BmpSize    :QWORD
LOCAL pd         :PICTDESC
LOCAL pPicture   :QWORD
LOCAL pStream    :QWORD
LOCAL hGlobal    :QWORD
LOCAL _FileName  :QWORD

    lea     rax,pd
    mov     PICTDESC.cbSizeofstruct[rax],SIZEOF PICTDESC
    mov     PICTDESC.picType[rax],PICTYPE_BITMAP
    mov     PICTDESC.bmp.hbitmap[rax],rcx
    mov     PICTDESC.bmp.hpal[rax],0
    mov     _FileName,rdx

    invoke  OleCreatePictureIndirect,ADDR pd,\
            ADDR IID_IPicture,0,ADDR pPicture

    test    rax,rax
    jnz     finish

    invoke  CreateStreamOnHGlobal,0,TRUE,ADDR pStream

    test    rax,rax
    jnz     releasePict

    coinvk  pPicture,IPicture,SaveAsFile,pStream,TRUE,ADDR BmpSize

    test    rax,rax
    jnz     releaseStream

    invoke  GetHGlobalFromStream,pStream,ADDR hGlobal

    test    rax,rax
    jnz     releaseStream

    invoke  GlobalLock,hGlobal
 
    invoke  WriteFileToDisc,_FileName,rax,BmpSize

releaseStream:

    coinvk  pStream,IStream,Release

releasePict:

    coinvk  pPicture,IPicture,Release

finish:

    ret
   
SaveBmpFromHandle ENDP

END

Title: Re: Saving a bitmap from handle
Post by: Vortex on April 02, 2025, 08:23:07 PM
Hi Pelle,

Testing Poasm V13 with the source files in the attachment, I receive the following error messages :

Code Select
E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 SaveBmpFromHandle.asm
E:\PellesC\sample\SaveBmpFromHandle.asm(9): error: Must be a constant integer expression.
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.inc(242): fatal error: Invalid use of ')'.

E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 Demo.asm
E:\PellesC\sample\Demo.asm(20): error: Must be a constant integer expression.
E:\PellesC\sample\Demo.asm(26): error: Stack parameter area can only hold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\Demo.asm(26): error: Stack parameter area can only hold 0 entries: increase value of PARMAREA.

E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 WriteFileToDisc.asm
E:\PellesC\sample\WriteFileToDisc.asm(13): error: Must be a constant integer expression.
E:\PellesC\sample\WriteFileToDisc.asm(26): error: Stack parameter area can only hold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\WriteFileToDisc.asm(26): error: Stack parameter area can onlyhold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\WriteFileToDisc.asm(26): error: Stack parameter area can onlyhold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\WriteFileToDisc.asm(37): error: Stack parameter area can onlyhold 0 entries: increase value of PARMAREA.

Poasm V12.00.1 assembles the same code without any issues.
Title: Re: Saving a bitmap from handle
Post by: Pelle on April 02, 2025, 09:26:34 PM
Same thing: new (internal) expression format.

Changing this:
Code Select
entry_point PROC PARMAREA=6*QWORDto this:
Code Select
entry_point PROC PARMAREA=6*sizeof QWORDfixes one of the problems. The other problem is the same (ignoring cascading errors).

There is an odd MASM feature that allows a type name to mean "size n bytes" in some places, but I'm not sure I want to fully support that (but I will think some more about it).
Title: Re: Saving a bitmap from handle
Post by: Vortex on April 02, 2025, 10:03:35 PM
Hi Pelle,

Thanks, specifying the sizeof operator in the source files eliminated some error messages.

This updated source file reports :

Code Select
E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 SaveBmpFromHandle.asm
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.inc(242): fatal error: Invalid use of ')'.

SaveBmpFromHandle.asm, Line 37 :

Code Select
    coinvk  pPicture,IPicture,SaveAsFile,pStream,TRUE,ADDR BmpSize
This is a macro to execute COM methods, here the SaveAsFile method of the IPicture interface.

SaveBmpFromHandle.inc , Line 242 :

Code Select
  attr=OPATTR(arg)
Title: Re: Saving a bitmap from handle
Post by: Pelle on April 03, 2025, 03:11:36 PM
Attached minimum changes for it to assemble...
Title: Re: Saving a bitmap from handle
Post by: Vortex on April 03, 2025, 09:42:35 PM
Hi Pelle,

Thanks, the modified source files can be assembled with Poasm Version 13.00.1

For those who are following this thread, Pelle did the following modifications in the example code :

- In the procedure definitions, the size of the QWORDs are specified with the operator sizeof :

Code Select
SaveBmpFromHandle PROC hBitmap:QWORD,FileName:QWORD PARMAREA=4*SIZEOF QWORD
- The arguments accepted by the statement FOR should be enclosed between angle brackets :

Code Select
@ArgI MACRO index:REQ, arglist:VARARG

LOCAL count, retstr

retstr TEXTEQU <>
count = 0

    FOR arg,<arglist>
Title: Re: Saving a bitmap from handle
Post by: Pelle on April 03, 2025, 09:59:42 PM
... for those who are really following this thread, POASM version 13.00.1 can be found here:
www.smorgasbordet.com/pellesc/1300/poasm_13_00_1.zip
until it's included in the next (hopefully last)  Release Candidate, in a few days...
Text only | Text with Images