Saving a bitmap from handle

[Vortex]

Hello,

Here is a function to save a bitmap from handle :

Code Select Expand


include SaveBmpFromHandle.inc

.data

IID_IPicture GUID <7BF80980h,0BF32h,101Ah,<8Bh,0BBh,00h,0AAh,00h,30h,0Ch,0ABh>>

.code

SaveBmpFromHandle PROC hBitmap:QWORD,FileName:QWORD PARMAREA=4*QWORD

LOCAL BmpSize    :QWORD
LOCAL pd         :PICTDESC
LOCAL pPicture   :QWORD
LOCAL pStream    :QWORD
LOCAL hGlobal    :QWORD
LOCAL _FileName  :QWORD

    lea     rax,pd
    mov     PICTDESC.cbSizeofstruct[rax],SIZEOF PICTDESC
    mov     PICTDESC.picType[rax],PICTYPE_BITMAP
    mov     PICTDESC.bmp.hbitmap[rax],rcx
    mov     PICTDESC.bmp.hpal[rax],0
    mov     _FileName,rdx

    invoke  OleCreatePictureIndirect,ADDR pd,\
            ADDR IID_IPicture,0,ADDR pPicture

    test    rax,rax
    jnz     finish

    invoke  CreateStreamOnHGlobal,0,TRUE,ADDR pStream

    test    rax,rax
    jnz     releasePict

    coinvk  pPicture,IPicture,SaveAsFile,pStream,TRUE,ADDR BmpSize

    test    rax,rax
    jnz     releaseStream

    invoke  GetHGlobalFromStream,pStream,ADDR hGlobal

    test    rax,rax
    jnz     releaseStream

    invoke  GlobalLock,hGlobal
 
    invoke  WriteFileToDisc,_FileName,rax,BmpSize

releaseStream:

    coinvk  pStream,IStream,Release

releasePict:

    coinvk  pPicture,IPicture,Release

finish:

    ret
   
SaveBmpFromHandle ENDP

END


[Vortex]

Hi Pelle,

Testing Poasm V13 with the source files in the attachment, I receive the following error messages :

Code Select Expand

E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 SaveBmpFromHandle.asm
E:\PellesC\sample\SaveBmpFromHandle.asm(9): error: Must be a constant integer expression.
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.inc(242): fatal error: Invalid use of ')'.

E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 Demo.asm
E:\PellesC\sample\Demo.asm(20): error: Must be a constant integer expression.
E:\PellesC\sample\Demo.asm(26): error: Stack parameter area can only hold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\Demo.asm(26): error: Stack parameter area can only hold 0 entries: increase value of PARMAREA.

E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 WriteFileToDisc.asm
E:\PellesC\sample\WriteFileToDisc.asm(13): error: Must be a constant integer expression.
E:\PellesC\sample\WriteFileToDisc.asm(26): error: Stack parameter area can only hold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\WriteFileToDisc.asm(26): error: Stack parameter area can onlyhold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\WriteFileToDisc.asm(26): error: Stack parameter area can onlyhold 0 entries: increase value of PARMAREA.
E:\PellesC\sample\WriteFileToDisc.asm(37): error: Stack parameter area can onlyhold 0 entries: increase value of PARMAREA.

Poasm V12.00.1 assembles the same code without any issues.

[Pelle]

Same thing: new (internal) expression format.

Changing this:

Code Select Expand

entry_point PROC PARMAREA=6*QWORDto this:

Code Select Expand

entry_point PROC PARMAREA=6*sizeof QWORDfixes one of the problems. The other problem is the same (ignoring cascading errors).

There is an odd MASM feature that allows a type name to mean "size n bytes" in some places, but I'm not sure I want to fully support that (but I will think some more about it).

[Vortex]

Hi Pelle,

Thanks, specifying the sizeof operator in the source files eliminated some error messages.

This updated source file reports :

Code Select Expand

E:\PellesC\sample>\PellesC\bin\poasm /AAMD64 SaveBmpFromHandle.asm
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.asm(37): error: Invalid use of ','.
E:\PellesC\sample\SaveBmpFromHandle.inc(242): fatal error: Invalid use of ')'.

SaveBmpFromHandle.asm, Line 37 :

Code Select Expand

    coinvk  pPicture,IPicture,SaveAsFile,pStream,TRUE,ADDR BmpSize
This is a macro to execute COM methods, here the SaveAsFile method of the IPicture interface.

SaveBmpFromHandle.inc , Line 242 :

Code Select Expand

  attr=OPATTR(arg)