Old Dog New tricks

[xsilvergs]

I'm back again with what should be very simple.

I'm adding a couple of integars together and want to show them in a message box with some text.

I would like a message box  to show something like this, Your answer is 5. The 5 being the total of the addition.

Is it like this, do I have to convert the int to a string and how do I include it?

      WCHAR wszBuffer[40];
      swprintf(wszBuffer, L"%i", total);
      MessageBox(hwndDlg, L"Your answer is ", L"Addition result", MB_OK|MB_SETFOREGROUND);

Thanks for any help

Tony

[JohnF]

WCHAR wszBuffer[40];
swprintf(wszBuffer, 39, L"%i", total);
MessageBox(hwndDlg, wszBuffer, L"Your answer is ", MB_OK|MB_SETFOREGROUND);

John

[xsilvergs]

Hi John

What I was trying to do have a line of text in the message box that was made up of "Your answer is 5". Is it possible to join text (Your answer is) and the wszBuffer contents together? Something like this, but it doesn't work.

MessageBox(hwndDlg, L"Text" & wszBuffer, L"Addition result", MB_OK|MB_SETFOREGROUND);

[xsilvergs]

I'm still trying but can't combine L"Some text" with wszBuffer into one line.

A little more help would be apreciated.

[JohnF]

WCHAR wszBuffer[40];
swprintf(wszBuffer, 39, L"Your answer is %i", total);
MessageBox(hwndDlg, wszBuffer, L"Title", MB_OK|MB_SETFOREGROUND);

John

[xsilvergs]

Thank you John.

I had just worked it out myself, that's only taken me 3 hours but we got there in the end.

[xsilvergs]

My next question is regarding joining of strings (concatenation).

I've declared str1, str2 and str3 as char, I would like to show the numbers as a string in a messagebox, here is the code I'm trying to use.

case BTN_ANS:
   {
      str1 = "1";
      str2 = "2";
      str3 = (char *)calloc(strlen(str1)  + strlen(str2) + 1, sizeof(char));
      WCHAR wszBuffer[40];
      swprintf(wszBuffer, L"Numbers are ", L"%s", str3);

MessageBox(hwndDlg, wszBuffer, L"My string is", MB_OK|MB_SETFOREGROUND);

Am I going about this in the wrong way and how should I do it?

Thank you

[JohnF]

WCHAR str1[] = L"1";
WCHAR str2[] = L"2";
WCHAR wszBuffer[40];
swprintf(wszBuffer, 39, L"Numbers are %ls and %ls", str1, str2);
MessageBox(0, wszBuffer, L"My string is", MB_OK|MB_SETFOREGROUND);

You should read up on these things, no one is going to answer these simple questions on an ongoing basis.

THIS:
swprintf(wszBuffer, L"Numbers are ", L"%s", str3);

It is the second time you wrote swprintf that way, even after I showed the right way. Try and see what's wrong with it.

John

[JohnF]

Also, one cannot assign characters this way

str1 = "1";

in C that is a no-no.

If the string has room you can copy with this

wcscpy(wchar_t * restrict targetstring, const wchar_t * restrict sourcestring);

Which would be

   WCHAR str1[8]; // 8 is large enough
   wcscpy(str1, L"1");

Or create the string like this

WCHAR str1[] = L"1";

To concatenate

WCHAR str1[] = L"1";
WCHAR str2[] = L"2";
WCHAR * str3; // note the *, str3 is a pointer to an array of WCHAR, but at this point it points nowhere.

With this next line we allocate memory and assign the address to str3. The extra sizeof(WCHAR) is for the double termination of the string
str3 = malloc(wcslen(str1) + wcslen(str1) + sizeof(WCHAR));

strlen() is no good for WideChar strings

Now do it
swprintf(str3, wcslen(str1) + wcslen(str1) + sizeof(WCHAR), L"%ls %ls", str1, str2);

MessageBox(0, str3, L"My string is", MB_OK|MB_SETFOREGROUND);

John

[xsilvergs]

John

Sorry if my questions seem simple but certain examples from the internet etc. don't seem to work. For example the:

swprintf(wszBuffer, 39, L"Numbers are %ls and %ls", str1, str2); won't work for me in pocket pc.

If I write it:

swprintf(wszBuffer, L"Numbers are %ls and %ls", str1, str2); it works fine.

There is probably an explanation for this but I haven't found it yet?

Thanks again for your help

Ps. I'll try your example you've just posted.

Tony

[JohnF]

Ok, maybe it is different on WINCE.

Have you read the C FAQ? Might help with general stuff.

http://www.faqs.org/faqs/C-faq/faq/

John

[JohnF]

Tony,

There is a mistake in my code when calculating the string length, you need to double for UNICODE, maybe best to create another variable.

WCHAR * str3;
int strLenght = ((wcslen(str1) + wcslen(str1)) * 2) + sizeof(WCHAR);
str3 = malloc(strLength);

Also you should free the memory when it is no longer required.

free(str3);

John

[xsilvergs]

Can somebody give me a clue please with my PocketPC problem?

I've now written some code to convert, sort and add, a text document containing ascii characters but I need to save the file with a new name.

The new name for the file is written in an Editbox. I then use GetDlgItemText to retieve the file name, this is in the format LPWSTR.

I am then trying to use f=fopen function with the name from the Editbox but of course it doesn't work because this want's a char *.

Could somebody explain how to convert please.

code used:
case BTN_SFA:
         GetDlgItemText(hwndDlg, TXT_FILE, wszBuffer, NELEMS(wszBuffer));
      
      f=fopen(,"w");
      {
      for(d=0;d<=e;d++)
         fprintf(f,"%i,",data[d]);
      }
      fclose(f);

Thanks

Tony

[sp00n]

Code: [Select]

char *filename;
wcstombs(filename, wszBuffer, wcslen(wszBuffer)+1);
f = fopen(filename, "w");if it isn't work try this:

Code: [Select]

wchar wczBuffer[260];
... //your code
char filename[260];
wcstombs(filename, wszBuffer, 260);
f = fopen(filename, "w");

[xsilvergs]

sp00n

Thank you. The char filename[260] works the other sample doesn't. I had tried using the wcstombs prior to writting but I couldn't get it to work. All I need to do is understand it now.

Thanks again

Tony